Issue 10768 - DMD does not show deprecation message for missing 'override' keyword #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated. |
…override' keyword If a class/struct/template is not speculatively instantiated, error gagging should be ungagged temporarily during its semantic. Use RAII idiom to do it reliably.
|
I think this pull, and the ongoing problems with gagging, show that the gagging system is an absolutely terrible design. We need to find a better way. |
WalterBright
added a commit
that referenced
this pull request
Aug 28, 2013
Issue 10768 - DMD does not show deprecation message for missing 'override' keyword
|
@WalterBright I think the big problem is using gagging for forward references. Together with the use of globals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10768
If a class/struct/template is not speculatively instantiated, error gagging should be ungagged temporarily during its semantic.
Use RAII idiom to do it reliably.