Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5985 - string enum fails with debugging enabled #257

Merged
merged 1 commit into from
Jul 21, 2011

Conversation

rainers
Copy link
Member

@rainers rainers commented Jul 17, 2011

http://d.puremagic.com/issues/show_bug.cgi?id=5985

do not try to output debug information for string enum fields, it is marked as imcomplete anyway.

WalterBright added a commit that referenced this pull request Jul 21, 2011
Issue 5985 - string enum fails with debugging enabled
@WalterBright WalterBright merged commit 6228a42 into dlang:master Jul 21, 2011
@WalterBright
Copy link
Member

This does not fix bugzilla 5985.

@rainers
Copy link
Member Author

rainers commented Jul 22, 2011

On 22.07.2011 00:00, WalterBright wrote:

This does not fix bugzilla 5985.

Hmmm, IIRC e->memtype was 0 when I created the patch.

It should say

 if (!e->members || !e->memtype || !e->memtype->isintegral())
     property |= 0x80;               // enum is forward referenced 

or not encodable

now in line 130. Should I create a new pull request?

braddr pushed a commit to braddr/dmd that referenced this pull request Oct 22, 2012
Fixed DST issues in std.datetime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants