New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4018 - __FILE__ and __LINE__ as default template parameters not set to instantiation point per spec #2617

Merged
2 commits merged into from Oct 3, 2013

Conversation

Projects
None yet
1 participant

9rnsr added some commits Oct 2, 2013

fix Issue 4018 - __FILE__ and __LINE__ as default template parameters…
… not set to instantiation point per spec

Also fixes __MODULE__, __FUNCITON__, and __PRETTY_FUNCTION__
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 2, 2013

Excellent. I like the re-done tests as well.

ghost commented Oct 2, 2013

Excellent. I like the re-done tests as well.

string getFuncTiargFunc (string name = __FUNCTION__ )() { return name; }
string getFuncTiargFunc2(string name = __PRETTY_FUNCTION__)() { return name; }
template getInstTiargFile (string name = __FILE__ ) { enum getInstTiargFile = name; }

This comment has been minimized.

@ghost

ghost Oct 3, 2013

Should we also add a templated aggregate test (Issue 11158) or is this covered by this test already? I guess it does if struct S(T) becomes template(T) { struct S { } }.

@ghost

ghost Oct 3, 2013

Should we also add a templated aggregate test (Issue 11158) or is this covered by this test already? I guess it does if struct S(T) becomes template(T) { struct S { } }.

This comment has been minimized.

@9rnsr

9rnsr Oct 3, 2013

Member

Not necessary. It's already covered by this test.

@9rnsr

9rnsr Oct 3, 2013

Member

Not necessary. It's already covered by this test.

ghost pushed a commit that referenced this pull request Oct 3, 2013

Merge pull request #2617 from 9rnsr/fix4018
Issue 4018 - __FILE__ and __LINE__ as default template parameters not set to instantiation point per spec

@ghost ghost merged commit 6c8f9ff into dlang:master Oct 3, 2013

1 check passed

default Pass: 10
Details

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment