Issue 11545 - Aggregate function literal member should not have access to enclosing scope

[9rnsr]

https://d.puremagic.com/issues/show_bug.cgi?id=11545

[yebblies]

Does it still work with 'delegate' instead of 'function' ?

[9rnsr]

Currently, declaring delegate in aggregate DeclDefs scope is not allowed (Error: function literals cannot be class members).

[Garciat]

I'm not sure if this will be fixed by this pull request in its current state, but it should also be noted that:

import std.stdio;

class hello {
    int function(int) f = function(int x) {
        return x;
    };
}

void main() {
    auto h = new hello();
    // segfaults
    writeln(h.f(42));
}

[yebblies]

How is this related to 11545?

[9rnsr]

This change is related to the improvement of test/fail_compilation/ice10259.d. Without this change, the added test case will cause ICE.

[9rnsr]

@Garciat Between class and struct, there's no difference to the issue. Your example will also be fixed by this.

[CyberShadow]

Thanks for fixing this! 👍

[CyberShadow]

I noticed a problem with this pull (not a regression):

import std.algorithm;
import std.array;

struct S
{
    static immutable int[] pairs = [];
    static immutable int[] pairTokens = pairs.map!(a => a).array();
}

This still fails to compile, with the cryptic message Error: this.__lambda3 has no value inside std.algorithm.

[ghost]

Is this an unrelated change?

[9rnsr]

No, it is necessary to skip invariant emission for the lambdas in aggregate member scope.

class C {
    enum x = () { ... };   // This lambda should not have invariant
    invariant {}
}

[ghost]

Right, what confused me was the missing override, but we're in C++. Doh!

[ghost]

LGTM other than the introduction of addPreInvariant and addPostInvariant, which seem like unrelated changes.

[ghost]

Auto-merge toggled on

[9rnsr]

Thanks!

[CyberShadow]

Thanks everyone! This is a great improvement.

DustMite master should now compile for everyone :)

[quickfur]

This PR introduced this bug: https://issues.dlang.org/show_bug.cgi?id=13424