Issue 10329 - Attributes not inferred for indirectly templated methods

[9rnsr]

https://d.puremagic.com/issues/show_bug.cgi?id=10329

This is the last step for the pure/@safe algorithms and ranges.

Except following two cases, all of instantiated function attributes will be inferred.

1. Virtual methods

   class C(T) {
       void foo() {}
   }
   pragma(msg, typeof(&C!int.foo));    // void function()

2. Non-eponymous functions which declared in template scope

   template X(T) {
       void foo(T) {}
   }
   pragma(msg, typeof(&X!int.foo));    // void function(int)

   (I'm not still sure this is an essential restriction, but currently it's necessary to avoid bug 10134).

After merging this PR, for example, following code will be runnable with git-head Phobos.

import std.algorithm, std.range;
void main() pure @safe
{
    int[][] ror =[[1,2,3]];
    auto r = joiner(ror);

    string res;
    foreach (e; chain("a", "b"))
        res ~= e;
    assert(res == "ab");
}

[WalterBright]

I noticed in clone.c there's an idPool("_xopCmp") and idPool("__xopCmp"). I have no idea why there are two different identifiers. Also, having a third one suggests that it needs to be moved into idgen.c. Same for __xopEquals.

[9rnsr]

I moved two-underscore names __xopEquals and __xopCmp to idgen.c.

The two functions _xopEquals and _xopCmp exist in druntime object module. So I did select one underscored name, similarly to _ArrayEq function.

[WalterBright]

Auto-merge toggled on

[9rnsr]

Thanks!

[monarchdodra]

Most awesome.