New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 11805 - Removal of Bool has critically broken expression evaluation #3015

Merged
merged 3 commits into from Dec 23, 2013

Conversation

Projects
None yet
3 participants
@yebblies
Member

yebblies commented Dec 23, 2013

This is what I mistakenly though checkToBoolean was already doing.

@WalterBright

https://d.puremagic.com/issues/show_bug.cgi?id=11805

@WalterBright

This comment has been minimized.

Show comment
Hide comment
@WalterBright

WalterBright Dec 23, 2013

Member

Thanks for the quick action on this.

Member

WalterBright commented Dec 23, 2013

Thanks for the quick action on this.

@yebblies

This comment has been minimized.

Show comment
Hide comment
@yebblies

yebblies Dec 23, 2013

Member

Pity it doesn't work...

Member

yebblies commented Dec 23, 2013

Pity it doesn't work...

@yebblies

This comment has been minimized.

Show comment
Hide comment
@yebblies

yebblies Dec 23, 2013

Member

AssertExp called checkToBoolean after it called optimize, unlike everywhere else. Updated.

Member

yebblies commented Dec 23, 2013

AssertExp called checkToBoolean after it called optimize, unlike everywhere else. Updated.

@yebblies

This comment has been minimized.

Show comment
Hide comment
@yebblies

yebblies Dec 23, 2013

Member

Too many issues to work out with interpreting and constfolding cast(bool). This is just a reversion and adding the test case now.

Member

yebblies commented Dec 23, 2013

Too many issues to work out with interpreting and constfolding cast(bool). This is just a reversion and adding the test case now.

@9rnsr

This comment has been minimized.

Show comment
Hide comment
@9rnsr

9rnsr Dec 23, 2013

Member

Auto-merge toggled on

Member

9rnsr commented Dec 23, 2013

Auto-merge toggled on

9rnsr added a commit that referenced this pull request Dec 23, 2013

Merge pull request #3015 from yebblies/issue11805
Issue 11805 - Removal of Bool has critically broken expression evaluation

@9rnsr 9rnsr merged commit 9adceed into dlang:master Dec 23, 2013

1 check passed

default Pass: 10
Details

@yebblies yebblies deleted the yebblies:issue11805 branch Dec 23, 2013

@yebblies

This comment has been minimized.

Show comment
Hide comment
@yebblies

yebblies Dec 23, 2013

Member

Thanks

Member

yebblies commented Dec 23, 2013

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment