ARM test suite fixes #3093
Merged
ARM test suite fixes #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { //can't store ulong.max-1 in double | ||
| } | ||
| else | ||
| static assert(false, "Test not implemented for this platform"); |
There was a problem hiding this comment.
FYI - this is a warning sign of an inherently bad test. :)
|
LGTM. |
|
Auto-merge toggled on |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to make the test suite pass on ARM.
It's mostly reducing the required precision of math tests or changes the test values if they're not valid for real==double systems.
Note: This is part of a set of changes which are required to get test suite & unit tests passing on ARM GDC. All necessary changes for GDC are here for reference:
https://github.com/jpf91/GDC/commits/arm-old
Once these pull requests are merged upstream I'll merge them into GDC as well.