Fix segfault regressions 5936 and 6351 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 24, 2011 16:32
…eturn member function with parameter. In functionParameters(), the return type should be inferred _before_ analysing the parameters, not afterwards.
The function declaration may not be available (eg, if it's a call to a variable). In such a case, we can fall back to using the function type instead.
Both are segfaults caused by pure/@safe inference.
WalterBright
added a commit
that referenced
this pull request
Aug 24, 2011
Fix segfault regressions 5936 and 6351
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Issue 6973 - static assert(isOutputRange!(OutputRange!int, int)) is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These bugs are very closely related. Both are segfaults related to pure/@safe inference; they're both caused by code in functionParameters() that incorrectly assumes parameters are non-null.
http://d.puremagic.com/issues/show_bug.cgi?id=5936
Regression(2.050): Segfault when forward-referencing pure auto-return member function with parameter.
http://d.puremagic.com/issues/show_bug.cgi?id=6351
Regression(2.054) Segfault: Vararg delegate as template param
which is a dup of 6341: Regression(2.054): Segfault with variadic delegate parameter