Issue 11201 - ICE: (symbol.c) -inline stops compilation #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Jun 17, 2014
Issue 11201 - ICE: (symbol.c) -inline stops compilation
|
This pull request introduced a regression: |
|
This pull request introduced a regression: |
WalterBright
reviewed
Feb 8, 2020
| /* Bugzilla 11201: CallExp is always non trivial expression, | ||
| * especially for inlining. | ||
| */ | ||
| if (e->op == TOKcall) |
There was a problem hiding this comment.
The addition of this if statement is what causes the regressions. Of course, it also appears to be the sole point of this PR despite all of the other changes, which may be just a bunch of refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=11201