Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG2.066a] Issue 12924 - deprecated("foo"); and deprecated; should not compile #3676

Merged
merged 2 commits into from
Jun 18, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jun 17, 2014

https://issues.dlang.org/show_bug.cgi?id=12924

'DeclarationBlock' that follows 'Attribute' should be parsed by parseBlock.

PrefixAttribute is used to check redundant/conflicting attributes over the mutual call between parseDeclDefs and parseBlock.

case LINKc: q = "C"; break;
case LINKwindows: q = "Windows"; break;
case LINKpascal: q = "Pascal"; break;
case LINKcpp: q = "C++"; break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings and logic appear twice here, and also the same logic is in attrib.c and hdrgen.c. Should be refactored. Also, LINKd is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added print functions for LINK, TRUST, and PROT., and used it here.

9rnsr added 2 commits June 18, 2014 16:00
'DeclarationBlock' that follows 'Attribute' should be parsed by parseBlock.

`PrefixAttribute` is used to check redundant/conflicting attributes over the mutual call between `parseDeclDefs` and `parseBlock`.
@WalterBright
Copy link
Member

Auto-merge toggled on

WalterBright added a commit that referenced this pull request Jun 18, 2014
[REG2.066a] Issue 12924 - deprecated("foo"); and deprecated; should not compile
@WalterBright WalterBright merged commit 77f4e95 into dlang:master Jun 18, 2014
@9rnsr 9rnsr deleted the fix12924 branch June 18, 2014 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants