Parser improvements to handle attributes #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2014
|
@WalterBright Could you merge this? I'd like to introduce "more strict" check for redundant/conflicting attributes in 2.066 release. This is the last piece for that. |
9rnsr
force-pushed
the
refactor_parse
branch
2 times, most recently
from
c99d24e to
ccaec7e
Compare
9rnsr
force-pushed
the
refactor_parse
branch
2 times, most recently
from
02a03f4 to
01503a9
Compare
9rnsr
force-pushed
the
refactor_parse
branch
2 times, most recently
from
7f0d387 to
b5c5844
Compare
|
@WalterBright ping. |
9rnsr
force-pushed
the
refactor_parse
branch
2 times, most recently
from
82543a9 to
f16c73f
Compare
|
@WalterBright This code logic cleanup has been proposed by you, in the PR #3689. @yebblies Do you have a time to review this PR? |
| { | ||
| OutBuffer buf; | ||
| StorageClassDeclaration::stcToCBuffer(&buf, stc); | ||
| if (*(buf.data + buf.offset - 1) == ' ') |
There was a problem hiding this comment.
Any reason not to use indexing here instead of pointer arith? This whole construct is pretty nasty.
There was a problem hiding this comment.
There was no reason. I replaced it with pointer indexing.
Check redundant/conflicting attributes between prefix and postfix
… VarDeclaration I'd like to store all prefix attributes to `Declaration::storage_class`, but currently it's not possible because of these behaviors.
|
Okie dokie. |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Oct 2, 2014
Parser improvements to handle attributes
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replace "storage class" word with "attribute" in diagnostic messages, because the latter is more general word.