fix Issue 12896 - ld.gold complains about bad relocations when building libphobos2.so

[MartinNowak]

Revert "Merge pull request #3597 from MartinNowak/fix879"

This reverts commit dc0cd23, reversing
changes made to e01af42.

[dnadlinger]

@MartinNowak: I'd appreciate if we could have a short chat about ironing out the few remaining kinks in shared library support. I have two ideas for this specific problem, one of which is ugly, but seems to work for LDC (just stupidly push a reference to the current module's module info ref symbol on the stack in the dso ctor). But there are a also couple of other issues where it would be great if we could make sure not to duplicate work. Just shoot me an email if you have a few minutes. I'll probably also be around on #d@freenode.net later this evening.

[WalterBright]

Handy link: https://issues.dlang.org/show_bug.cgi?id=12896

And Martin's rationale:

The ld.gold linker is complaining about a bad offset for the fake relocations added to pin the deh_eh and the minfo section. Those are 0-sized NONE relocations added to the end of the d_dso_init function. The gold linker complains, because it thinks there is no space for the relocation (the section only has 56 bytes) even though it doesn't require any space. A simple solution would be to set the relocation offset to 0 (i.e. the begin of d_dso_init) but there are further issues with --gc-sections and ld.gold which necessitate a different solution, so reverting is the best option for now.

[WalterBright]

Auto-merge toggled on

[dnadlinger]

Further discussion at the original bug report: https://issues.dlang.org/show_bug.cgi?id=879