Issue 13113 - cannot build druntime's gc.d with -debug=INVARIANT, bad @nogc inference?

[9rnsr]

https://issues.dlang.org/show_bug.cgi?id=13113

Bypass attribute check on direct invariant calls.

[WalterBright]

I understand where you're coming from with this, but am unhappy with a few things:

1. I agree you found a bug with the invariant not being inserted into the generated destructor. This shows a more fundamental issue, that being the logic of when they are inserted is not consistent. The hackish way this PR avoids doing attribute checking on invariant is also indicative of a structural problem.
2. Generated functions should be processed like function literals, that's pretty much just what they are. Having a separate and differently implemented set of semantics to deal with them is indicative of a structural problem in the compiler.
3. I'm pretty uneasy about exempting invariant from attribute checking.

That leaves us with "what do we do about this release"? Both yours and my solutions have problems. What do you think?

[WalterBright]

I'll pull this in the interests of getting the release out, but points 1 and 2 are still valid.

[WalterBright]

Auto-merge toggled on