[critical] fix Issue 9449 - Static arrays of 128bit types segfault on initializatio... #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Incorrect calling of memset128ii
WalterBright
changed the title
|
This needs to be pulled. It's critical, and shouldn't be controversial. |
|
Auto-merge toggled on |
|
Without knowing your backend too much, it seems a bit hacky to hard-code the vector alignment handling like that, but from what I can make out, it seems like a reasonable fix for the specific issues for now. We really need to figure out how to handle DMD backend changes. Maybe it's time (with DDMD, probably) to split off the Digital Mars glue layer/backend into a separate repository with less strict code review policies? |
dnadlinger
added a commit
that referenced
this pull request
Jul 21, 2014
[critical] fix Issue 9449 - Static arrays of 128bit types segfault on initializatio...
|
The back end is a giant mess of special cases. Look at the instruction set! I think what we've got for process is ok. |
LemonBoy
added a commit
to LemonBoy/dmd
that referenced
this pull request
Mar 27, 2018
Hopefully completes what dlang#3784 started.
ibuclaw
pushed a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2022
core.sys.elf: Move shared ELF types and values to a common module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n. Incorrect calling of memset128ii
This also exposed a code gen issue with 32 bit OSX SIMD code, also fixed here.
https://issues.dlang.org/show_bug.cgi?id=9449
Requires dlang/druntime#901 to be pulled first.