Issue 6062 - segv in dmd/64 with assoc array literals #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new druntime interface uses `ExpressionsToStaticArray` to generate the arguments for the arrays of keys and values passed to the runtime when creating an array literal. When called, the key and value types have already completed semantic, but semantic is called again while resolving the static array type used, with a `NULL` scope. As `TypeAArray::semantic` does not have an early exit, the `NULL` scope replaces the proper instantiation scope. When it comes time to run semantic on the backing `TemplateInstance` for the aa, the `NULL` scope causes a segfault.
WalterBright
added a commit
that referenced
this pull request
Sep 14, 2011
Issue 6062 - segv in dmd/64 with assoc array literals
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Supplemental changes for 3235 & 6714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new druntime interface uses
ExpressionsToStaticArrayto generate the arguments for the arrays of keys and values passed to the runtime when creating an array literal. When called, the key and value types have already completed semantic, but semantic is called again while resolving the static array type used, with aNULLscope. AsTypeAArray::semanticdoes not have an early exit, theNULLscope replaces the proper instantiation scope. When it comes time to run semantic on the backingTemplateInstancefor the aa, theNULLscope causes a segfault.http://d.puremagic.com/issues/show_bug.cgi?id=6062