Supplemental changes of druntime/pull/72 - Issue 1824 - Object not const correct #387

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
3 participants
Member

9rnsr commented Sep 16, 2011

http://d.puremagic.com/issues/show_bug.cgi?id=1824
D-Programming-Language#387
D-Programming-Language/druntime#72
D-Programming-Language/phobos#262

This pull request does not change compiler, but fixes only dmd test suites.

2011/10/15
This change also fix issue 3780, because it requires const equality comparison for member classes.

requires: druntime git://github.com/9rnsr/druntime.git constApply
requires: phobos git://github.com/9rnsr/phobos.git constApply

Member

yebblies commented Sep 16, 2011

The pull request autotester currently can only handle a pull request dependencies in the order dmd -> druntime -> phobos, unfortunately. It will work correctly if you put a requires: line for the druntime and phobos pull requests inside this pull request, but will choke with the way it's currently arranged.

Member

9rnsr commented Sep 16, 2011

@yebblies
Updated. Is this correct?

And, I want to avoid your autotester running on druntime#72 and phobos#262.
Do you know how to do it?

Member

yebblies commented Sep 16, 2011

Great, it should be able to handle it now. It'll be about 18 hours until it shows up on the results page.
If the branch for a druntime or phobos pull request is 'requires:'ed by another pull request, it will be skipped.

Member

9rnsr commented Oct 15, 2011

This change now also fix issue 3780, because it requires const equality comparison for member classes.

@yebblies yebblies added a commit to yebblies/dmd that referenced this pull request Apr 14, 2012

@yebblies yebblies Reintroduce the fix for issue 3632, without the dependency on fixing …
…issue 1824.

Revert the parts in clone.c that were commented out, so pull #387 can merge cleanly.
f9c21c2
Member

9rnsr commented Apr 22, 2012

Rebased, and removed changes for 3780, because it's something wrong.

@WalterBright WalterBright added a commit that referenced this pull request Jul 9, 2012

@WalterBright WalterBright Merge pull request #387 from 9rnsr/constApply
Supplemental changes of druntime/pull/72 - Issue 1824 - Object not const correct
271085b

@WalterBright WalterBright merged commit 271085b into dlang:master Jul 9, 2012

@9rnsr 9rnsr added a commit to 9rnsr/dmd that referenced this pull request Jul 22, 2012

@9rnsr 9rnsr Revert "Merge pull request #387 from 9rnsr/constApply"
This reverts commit 271085b, reversing
changes made to 782fe63.
25d18e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment