Issue 13955 - 64 bit C ABI not followed for passing structs with mixed floating types #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -429,7 +429,8 @@ TypeTuple *toArgTypes(Type *t) | |||
| { | |||
| if (t1->isfloating() && t2->isfloating()) | |||
| { | |||
| if (t1->ty == Tfloat64 && t2->ty == Tfloat64) | |||
| if ((t1->ty == Tfloat32 || t1->ty == Tfloat64) && | |||
| (t2->ty == Tfloat32 | t2->ty == Tfloat64)) | |||
There was a problem hiding this comment.
I assume the xor here is a typo, and it should instead be logical or.
There was a problem hiding this comment.
bitwise or... I always get my or's mixed up. :)
…mixed floating types Check code in argtypes.c should be checking that both types can be passed in xmm registers.
|
Auto-merge toggled on |
ibuclaw
added a commit
that referenced
this pull request
Jan 8, 2015
Issue 13955 - 64 bit C ABI not followed for passing structs with mixed floating types
|
@yebblies: Did you find this using a fuzzer? Then I don't need to finish mine. ;) |
|
@klickverbot Yep, here it is: https://gist.github.com/yebblies/a848bd1326b380b471e8 @ibuclaw Thanks. |
|
@yebblies: Thanks, this will come in handy for me soon. |
kinke
referenced
this pull request
in kinke/ldc
Feb 7, 2015
…ng point numbers.
DMD is clearly wrong here for structs > 8 bytes and <= 16 bytes.
It passes the whole struct in memory if either exactly one field is a fp number
or if both fields are fp numbers and they are not both doubles.
The official docs (and Clang) don't have such a restriction. A simple struct
{ double a; int b; } is passed as if it were two separate arguments; a in a FP
register if available, b in a GP register if available.
This change probably leads to issues when trying to fetch such a struct passed
as vararg via va_arg; druntime (core.stdc.stdarg and core.vararg) would most
likely need to be fixed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check code in argtypes.c should be checking that both types can be passed in xmm registers.
https://issues.dlang.org/show_bug.cgi?id=13955