Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept @pure @nothrow @return attributes #4341

Merged
merged 1 commit into from
Jan 26, 2015
Merged

Conversation

WalterBright
Copy link
Member

Not much to it.

@Hackerpilot
Copy link
Member

😄
Looks like at least part of my DIP64 is happening.

@andralex
Copy link
Member

Auto-merge toggled on

@andralex
Copy link
Member

@WalterBright take a look at the failures.

@Orvid
Copy link
Contributor

Orvid commented Jan 26, 2015

The failures I see in the tests are from the DIP 25 PR.

@WalterBright
Copy link
Member Author

Here's the code that fails in src/rt/sections_elf_shared.d:

ThreadDSO* findThreadDSO(DSO* pdso)
{
    foreach (ref tdata; _loadedDSOs)
        if (tdata._pdso == pdso) return &tdata;
    return null;
}

Looks like a case not considered in DIP25, i.e. what to do about ref's in foreach statements.

@WalterBright
Copy link
Member Author

Which has nothing to do with this PR.

@Orvid
Copy link
Contributor

Orvid commented Jan 26, 2015

Instead you wanted the druntime PR. This one looks fine though.

andralex added a commit that referenced this pull request Jan 26, 2015
@andralex andralex merged commit 6b86b12 into dlang:master Jan 26, 2015
@WalterBright WalterBright deleted the atkwd branch January 26, 2015 08:55
@jmdavis
Copy link
Member

jmdavis commented Jan 27, 2015

I would point out that if this doesn't get reverted, then we need to update the error message relating to @ attributes accordingly: https://issues.dlang.org/show_bug.cgi?id=14064 . The message needs to be updated for @nogc regardless, but with this change, three more are missing from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants