-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug 14195: Added C++ mangling for passing function signatures #4419
Conversation
|
How hard is it to do linux mangling as well? I'd prefer the tests were in cppa/cppb so that the mangling is automatically verified. |
| buf.writeByte('$'); | ||
| buf.writeByte('$'); | ||
| buf.writeByte('A'); // mutable | ||
| buf.writeByte('6'); // Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using writestring("$$A6") would be more compact.
|
I'd like to see a test for this in cppa/cppb as well for the same reason @yebblies stated. And such would provide motivation, and a test case, for doing the Linux mangling as well. |
|
Juding from the source code this is already implemented for linux. I will move the tests over to cppa/cppb as soon as I find time. |
1819f11 to
a986740
Compare
|
I tried enabeling the test on non-windows systems and got the following error message from the build machines: undefined reference to `DelegateTest1(Delegate1<void ()>)' |
…s template parameters.
|
Sorry, forget what I said. It is already correctly implemented on linux, I just made a mistake transitioning the test to cppa/cppb. |
|
In future pull requests please remember to add a bugzilla link to the description. |
|
Auto-merge toggled on |
Fixed bug 14195: Added C++ mangling for passing function signatures
Added support for mangling the C++ equivalent type of:
The corresponding D code can be found in cppmangle.d. I hit this issue when trying to bind a C++ Delegate implementation to D.