Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 14279 - [REG:git-head]Failed to make dmd because of idgen : HO... #4492

Merged
merged 1 commit into from
Mar 14, 2015

Conversation

WalterBright
Copy link
Member

@yebblies
Copy link
Member

Unfortunately this can't work, because a definition in the makefile will override a definition in the environment. Digital mars make doesn't recognize the ?= operator.

@yebblies
Copy link
Member

Also, HOST_DC=dmd will pick up the dmd that just got built, which is not usually what you want.

@WalterBright
Copy link
Member Author

Apparently the autotester is relying on environment variables.

@yebblies
Copy link
Member

Yep.

@WalterBright
Copy link
Member Author

Redid to make it a comment.

@yebblies
Copy link
Member

Auto-merge toggled on

yebblies added a commit that referenced this pull request Mar 14, 2015
fix Issue 14279 - [REG:git-head]Failed to make dmd because of idgen : HO...
@yebblies yebblies merged commit 339cd18 into dlang:master Mar 14, 2015
@CyberShadow
Copy link
Member

Unfortunately this can't work, because a definition in the makefile will override a definition in the environment.

Why does it have to be in the environment, and not a make parameter?

@WalterBright
Copy link
Member Author

I run it using a make parameter rather than an environment variable, so it does work.

@yebblies
Copy link
Member

Why does it have to be in the environment, and not a make parameter?

A make parameter will work, but I think we need to support setting it via an environment variable.

@CyberShadow
Copy link
Member

This isn't very different from the existing settings. People who need to override the setting can use their own build script which invokes the makefile.

I think it's more valuable to not force people to create a HOST_DC variable, and thus provide a sensible default out of the box, than allowing configuring HOST_DC through the environment in win32.mak.

@yebblies
Copy link
Member

I was initially aiming for that, but Brad set up the autotester to pass it via the environment.
As for a sensible default, HOST_DC=dmd will pick up the system dmd on the first build, then pick up the just-built dmd after that. I'm not sure what default doesn't have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants