-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 14279 - [REG:git-head]Failed to make dmd because of idgen : HO... #4492
Conversation
|
Unfortunately this can't work, because a definition in the makefile will override a definition in the environment. Digital mars make doesn't recognize the |
|
Also, HOST_DC=dmd will pick up the dmd that just got built, which is not usually what you want. |
|
Apparently the autotester is relying on environment variables. |
|
Yep. |
|
Redid to make it a comment. |
|
Auto-merge toggled on |
fix Issue 14279 - [REG:git-head]Failed to make dmd because of idgen : HO...
Why does it have to be in the environment, and not a |
|
I run it using a make parameter rather than an environment variable, so it does work. |
A make parameter will work, but I think we need to support setting it via an environment variable. |
|
This isn't very different from the existing settings. People who need to override the setting can use their own build script which invokes the makefile. I think it's more valuable to not force people to create a HOST_DC variable, and thus provide a sensible default out of the box, than allowing configuring HOST_DC through the environment in win32.mak. |
|
I was initially aiming for that, but Brad set up the autotester to pass it via the environment. |
...ST_DC missing
https://issues.dlang.org/show_bug.cgi?id=14279