-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong #4666
Conversation
|
Auto-merge toggled on |
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
|
I think this should have gone into branch stable, since it's a regression. I think we need to update the D wiki on how to properly do this. @MartinNowak, what is the proper way to do this, and how do you know whether something goes into stable or not? |
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
It goes into stable if it makes the compiler more stable :), i.e. regression fixes and bugfixes with low risk. |
|
I think the question is, should it go to stable at this stage, when 2.067.1 is out and 2.068 is next ? Will there be 2.067.2 ? I assume at some point master is going to be merged into stable. |
Always stable, simpler and leaves us more options, e.g. releasing 2.067.2, even though that isn't planned. |
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
|
I'll try my hand at updating the wiki. |
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong Conflicts: test/runnable/testswitch.d Signed-off-by: Martin Krejcirik <mk@krej.cz>
* upstream/dmd-1.x: (21 commits) Accept `static struct` at statement context Merge pull request dlang#4710 from WalterBright/dtcodepool Merge pull request dlang#4708 from WalterBright/dtsize Merge pull request dlang#4707 from WalterBright/rmjunk Merge pull request dlang#4703 from WalterBright/rmMSDOS Merge pull request dlang#4702 from WalterBright/fix14634 Merge pull request dlang#4679 from WalterBright/envsections Merge pull request dlang#4701 from WalterBright/rmcond Merge pull request dlang#4700 from WalterBright/rmINTSIZE Merge pull request dlang#4697 from WalterBright/rmLONGLONG Merge pull request dlang#4696 from WalterBright/rmjhandle Merge pull request dlang#4695 from WalterBright/go Merge pull request dlang#4694 from WalterBright/rmregister Merge pull request dlang#4693 from WalterBright/unambig fix cherry-pick so it compiles Merge pull request dlang#4668 from WalterBright/twicebaked Merge pull request dlang#4666 from WalterBright/fix14587 Merge pull request dlang#4655 from WalterBright/argvToStrings Merge pull request dlang#4652 from WalterBright/runargs2 merge in D2 sections[] code ... Fixes dlang#64.
https://issues.dlang.org/show_bug.cgi?id=14587
This is a critical bug fix.