Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 14587 - generated 64 bit code for switch jump tables is wrong #4666

Merged
merged 1 commit into from
May 17, 2015

Conversation

WalterBright
Copy link
Member

@WalterBright WalterBright changed the title fix Issue 14587 - DMD 2.067.1 generating crashing binary on OSX fix Issue 14587 - generated 64 bit code for switch jump tables is wrong May 17, 2015
@andralex
Copy link
Member

Auto-merge toggled on

@WalterBright WalterBright added the Severity:Regression PRs that fix regressions label May 17, 2015
andralex added a commit that referenced this pull request May 17, 2015
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
@andralex andralex merged commit a7d1edb into dlang:master May 17, 2015
@WalterBright WalterBright deleted the fix14587 branch May 17, 2015 20:38
andralex added a commit that referenced this pull request May 17, 2015
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
@schveiguy
Copy link
Member

I think this should have gone into branch stable, since it's a regression. I think we need to update the D wiki on how to properly do this. @MartinNowak, what is the proper way to do this, and how do you know whether something goes into stable or not?

tramker pushed a commit to tramker/dmd that referenced this pull request May 18, 2015
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
@MartinNowak
Copy link
Member

how do you know whether something goes into stable or not?

It goes into stable if it makes the compiler more stable :), i.e. regression fixes and bugfixes with low risk.

@tramker
Copy link
Contributor

tramker commented May 20, 2015

I think the question is, should it go to stable at this stage, when 2.067.1 is out and 2.068 is next ? Will there be 2.067.2 ? I assume at some point master is going to be merged into stable.

@MartinNowak
Copy link
Member

I think the question is, should it go to stable at this stage, when 2.067.1 is out and 2.068 is next ? Will there be 2.067.2 ? I assume at some point master is going to be merged to stable.

Always stable, simpler and leaves us more options, e.g. releasing 2.067.2, even though that isn't planned.

tramker pushed a commit to tramker/dmd that referenced this pull request May 20, 2015
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
@schveiguy
Copy link
Member

I'll try my hand at updating the wiki.

tramker pushed a commit to tramker/dmd that referenced this pull request May 25, 2015
fix Issue 14587 - generated 64 bit code for switch jump tables is wrong
Conflicts:
	test/runnable/testswitch.d

Signed-off-by: Martin Krejcirik <mk@krej.cz>
mihails-strasuns-sociomantic pushed a commit to mihails-strasuns-sociomantic/dmd that referenced this pull request Oct 28, 2015
* upstream/dmd-1.x: (21 commits)
  Accept `static struct` at statement context
  Merge pull request dlang#4710 from WalterBright/dtcodepool
  Merge pull request dlang#4708 from WalterBright/dtsize
  Merge pull request dlang#4707 from WalterBright/rmjunk
  Merge pull request dlang#4703 from WalterBright/rmMSDOS
  Merge pull request dlang#4702 from WalterBright/fix14634
  Merge pull request dlang#4679 from WalterBright/envsections
  Merge pull request dlang#4701 from WalterBright/rmcond
  Merge pull request dlang#4700 from WalterBright/rmINTSIZE
  Merge pull request dlang#4697 from WalterBright/rmLONGLONG
  Merge pull request dlang#4696 from WalterBright/rmjhandle
  Merge pull request dlang#4695 from WalterBright/go
  Merge pull request dlang#4694 from WalterBright/rmregister
  Merge pull request dlang#4693 from WalterBright/unambig
  fix cherry-pick so it compiles
  Merge pull request dlang#4668 from WalterBright/twicebaked
  Merge pull request dlang#4666 from WalterBright/fix14587
  Merge pull request dlang#4655 from WalterBright/argvToStrings
  Merge pull request dlang#4652 from WalterBright/runargs2
  merge in D2 sections[] code
  ...

Fixes dlang#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity:Regression PRs that fix regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants