fix Issue 14596 - Error: e2ir: cannot cast malloc(42u) of type void* … #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does a similar issue exist for static arrays? |
|
Yep, it exist, I will add this fix too |
| void main() { | ||
| import core.stdc.stdlib : malloc; | ||
| auto ptr = cast(char[]) malloc(42); | ||
| } |
There was a problem hiding this comment.
As a better place, you can add the new test case to fail_compilation/fail_casting.d.
There was a problem hiding this comment.
You can also remove the dependency to druntime as follows.
void* p = null;
auto arr = cast(char[])p;And using malloc function is not good for a platform independent test case. It takes size_t parameter, so the integer value 42 will be uint in 32bit target, and ulong in 64bit target. Finally the difference will appear in the error message.
Let's not use it to fix the current auto-tester failure.
Kozzi11
force-pushed
the
14596
branch
2 times, most recently
from
646ee84 to
2bcf5dc
Compare
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
May 19, 2015
fix Issue 14596 - Error: e2ir: cannot cast malloc(42u) of type void* …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to type char[]