-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REG2.055/2.063] Issue 9279 - Static array return value implicitly converted to immutable dynamic array #4687
Conversation
| @@ -258,6 +251,12 @@ bool checkEscapeRef(Scope *sc, Expression *e, bool gag) | |||
| ::error(loc, format, s->toChars()); | |||
| result = true; | |||
| } | |||
| void error(Loc loc, const char *format, Expression *e) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about adding yet another error function. How much uglier would it be without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know someone said that we should not do both refactoring and regression fix in a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I merged to error functions into one, by taking RootObject *o.
3db6c17 to
1dcede3
Compare
|
Auto-merge toggled on |
|
once the magicport issue is solved... |
|
@WalterBright Sorry, fixed ddmd issue. |
…mutable dynamic array
[REG2.055/2.063] Issue 9279 - Static array return value implicitly converted to immutable dynamic array
|
I think this PR broke building the docs: |
|
@CyberShadow The problem is introduced by the Phobos change: dlang/phobos#3381 |
|
Thanks. (Strange, it was merged at 04:52 but my 05:00 build succeeded) |
https://issues.dlang.org/show_bug.cgi?id=9279
Implement more escape analysis.