Issue 12487 - DMD correctly reports excessive CTFE recursion, but not template recursion #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnsr
force-pushed
the
fix12487
branch
2 times, most recently
from
f812c0f to
537fceb
Compare
|
Fixed trailing space in |
|
Rebased on master, and ready for ddmd. |
9rnsr
force-pushed
the
fix12487
branch
5 times, most recently
from
bb48114 to
5e4ea47
Compare
|
Couldn't this be 5 PRs instead of one? |
|
@WalterBrigt A commit depends on the previous commits. So this cannot be 5 independent PRs. |
|
The 'Refactor ScopeExp::semantic()' appears to be independent. |
|
@WalterBright Yes, but latter 4 commits depend on that refactoring. I don't like to create multiple "dependent PRs", because their maintenance is troublesome. |
|
@WalterBright I've separated the first commit to #5132. Is that reviewable/mergeable to you? |
9rnsr
force-pushed
the
fix12487
branch
3 times, most recently
from
db6679c to
4ecebca
Compare
|
2nd separation: #5135 |
|
3rd separation: #5142 |
9rnsr
force-pushed
the
fix12487
branch
2 times, most recently
from
46977ea to
3e4497d
Compare
|
Last separation! #5149 |
… not template recursion
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Oct 4, 2015
Issue 12487 - DMD correctly reports excessive CTFE recursion, but not template recursion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=12487
When an instance that will be converted to a constant exists, the instance representation "foo!tiargs" is treated like a variable name, and its recursive appearance check (note that it's equivalent with a recursive instantiation of foo) is done separately from the recursive definition check for the eponymous enum variable declaration.
By the approach, we can remove problematic
global.gagcheck inDsymbolExp::semantic()without breakingfail_compilation/diag10141.d.