Issue 5416 & 5889 - typeof(null) should have a type of its own #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| void TypeNull::toCBuffer(OutBuffer *buf, Identifier *ident, HdrGenState *hgs) | ||
| { | ||
| buf->writestring("null_t"); |
There was a problem hiding this comment.
I think this should be
buf->writestring("typeof(null)");
WalterBright
added a commit
that referenced
this pull request
Nov 25, 2011
Issue 5416 & 5889 - typeof(null) should have a type of its own
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Modified moduleName trait to only include the package name if it is valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 5416 - null should have a type of its own
Issue 5899 - auto-return function cannot match 'null' with reference type.
typeof(null)should have the own type, that is implicitly convertible to any reference types.In binary level,
typeof(null)is treated asvoid*I think this is also useful for
NonNull!T, because we can rejectNonNull!T p = null;statically.