Issue 14730 - Wrong closure var access with -inline #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| struct S | ||
| { | ||
| int n; | ||
| int get() { return x; } // x will be a cloaure variable |
There was a problem hiding this comment.
closure, not cloauasre (I gave up trying to type the typo)
|
I noticed that, moving the closure vars offset calculation into front-end will cause breaking of currently working code. Look at the added test case But I think it's questionable behavior, because I also found a @nogc violation issue around that. Anyway, I changed the bugfix way to more conservative. |
|
Rebased on master, and ready for ddmd. |
|
|
OK. |
|
Auto-merge toggled on |
It's necessary to avoid breaking of test14730x(). But I think it's questionable. See: https://issues.dlang.org/show_bug.cgi?id=14771
ibuclaw
added a commit
that referenced
this pull request
Feb 7, 2016
Issue 14730 - Wrong closure var access with -inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14730