-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 14811 : allow to exclude current directory from search path in dmd #4823
Conversation
|
Service: https://issues.dlang.org/show_bug.cgi?id=14811 Can you explain why this is useful/needed? Also, please use a more descriptive commit message than "_". |
|
Done |
|
@timotheecour It seems you haven't pushed your changes... Depending on how you did the changes, you probably need to use |
|
amended commit message; I am seeing the changes now |
|
|
@timotheecour - in sore need of rebasing here. Solution doesn't really seem very appropriate though. |
|
I think I would prefer that the current working directory was not hard coded in the compiler, but rather included by default as |
|
@timotheecour Should we close this? |
|
This PR is awfully old and doesn't seem to have much support. Furthermore, queries to the author have gone unanswered, so I'm assuming this PR is abandoned. I'm closing this for now; it can always be reopened or resubmitted. |
|
Couple of notes.
|
dmd implicitly adds current directory to search path, causing trouble when user has both foo/fun1.d and fun1.d and cwd=foo. This fixes this by adding a flag -exclude_cwd_from_imports.
Reduced use case:
see https://github.com/timotheecour/dsnippet/tree/master/bug_14811
make
..//main.d(3): Error: module foo.fun1 from file fun1.d conflicts with another module fun1 from file ..//foo/fun1.d
With my modification (adds a flag -exclude_cwd_from_imports):
make with_flag
works
See also https://issues.dlang.org/show_bug.cgi?id=14811