Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddmd cleanup and fixes #4924

Merged
merged 4 commits into from
Aug 23, 2015
Merged

ddmd cleanup and fixes #4924

merged 4 commits into from
Aug 23, 2015

Conversation

MartinNowak
Copy link
Member

  • cleanup makefiles
  • drop -O -inline by default (too slow)
  • remove unused headers and magicport
  • update travis-ci test

yebblies
yebblies reviewed Aug 23, 2015
View reviewed changes
src/win32.mak
$(DEL) id.h id.c id.d
$(DEL) verstr.h
$(DEL) $(MAGICPORT) $(MAGICPORTDIR)\*.obj
$(DEL) impcnvtab.c impcnvgen.exe optabgen.exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impcnvtab.d?

@yebblies
Copy link
Member

Needs #4927

@MartinNowak
Copy link
Member Author

updated

@yebblies
Copy link
Member

Auto-merge toggled on

yebblies added a commit that referenced this pull request Aug 23, 2015
@yebblies
Merge pull request #4924 from MartinNowak/cpp_to_d
69400b9 
ddmd cleanup and fixes
@yebblies yebblies merged commit 69400b9 into dlang:master Aug 23, 2015
@MartinNowak
Copy link
Member Author

thx

@MartinNowak MartinNowak deleted the cpp_to_d branch August 23, 2015 10:46
@Temtaime
Copy link
Contributor

DDMD is not buildable with msvc due name mangling and troubles with longdouble.
Anyone to fix it ?

@rainers
Copy link
Member

rainers commented Aug 23, 2015

DDMD is not buildable with msvc due name mangling and troubles with longdouble.
Anyone to fix it ?

I noticed this, too. Not sure if I'll be able to provide patches. See also #4929

@yebblies
Copy link
Member

Please file bugs for the mangling problems. I wouldn't be surprised to find some codegen problems too.

@rainers
Copy link
Member

rainers commented Aug 23, 2015

Please file bugs for the mangling problems.

https://issues.dlang.org/show_bug.cgi?id=14951

@CyberShadow
Copy link
Member

This pull request caused a ~50% increase in compilation real time for the "Vibe.d diet templates" test on http://digger.k3.1azy.net/trend/

Maybe because of this?

drop -O -inline by default (too slow)

@CyberShadow CyberShadow mentioned this pull request Nov 3, 2015
Merged
@yebblies yebblies mentioned this pull request Apr 27, 2016
Closed
@CyberShadow
Copy link
Member

Currently bisecting why older versions of D stopped building on Arch Linux and bisection shows this PR as the one after which things build successfully. However, 28f9199 mixes a lot of various changes, including changes in behaviour and no-op refactorings.

Please, make your commits more granular!

@wilzbach wilzbach mentioned this pull request Dec 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinNowak @yebblies @Temtaime @rainers @CyberShadow