Issue 6912 - const(T)[]/immutable(T)[] can be implicitly cast to inout(const(T)[])/inout(immutable(T)[]) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return x; | ||
| } | ||
|
|
||
| /************************************/ | ||
|
|
There was a problem hiding this comment.
The test is flawed.
Try to add a positive test, it will fail because the delegate is no inout function.
static assert(is(typeof({ inout(int) wda = 2; })));
There was a problem hiding this comment.
Oops, thank you for your pointing out.
I'll fix this test.
…t(const(T)[])/inout(immutable(T)[])
| static assert(!is(typeof(testinout!q{ int [] mda; inout( const(int)[]) wda = mda; }))); | ||
| static assert(!is(typeof(testinout!q{ const(int)[] cda; inout( const(int)[]) wda = cda; }))); | ||
| static assert(!is(typeof(testinout!q{ immutable(int)[] ida; inout( const(int)[]) wda = ida; }))); | ||
| static assert(!is(typeof(testinout!q{ immutable(int)[] ida; inout(immutable(int)[]) wda = ida; }))); |
There was a problem hiding this comment.
This is not correct. immutable(int)[] should implicitly cast inout(immutable(int)[]), because the inout qualifier only talks about the head of the array.
It is probably my fault, because I got the title of the bug report wrong. (the bug report does not actually talk about immutable).
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Fix using F!() syntax instead of F[] in typetuple.d documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=6912
Fix inout matching on dynamic array and associative array types.