-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use linker generated section brackets #5047
Conversation
|
Requires dlang/druntime#1379 |
faa103d to
24b0931
Compare
| @@ -463,13 +462,15 @@ static IDXSTR elf_addmangled(Symbol *s) | |||
| * sz = symbol size | |||
| * typ = symbol type | |||
| * bind = symbol binding | |||
| * segidx = segment index for segment where symbol is defined | |||
| * sec = index of section where symbol is defined | |||
| * vsblty = visibility of symbol | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to complain about names, but why not just call it visibility?
Also, what is visibility of names? You could add STV_xxxx to the explanatory comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Nice. I wish I'd known about that linker feature sooner! |
- rename sections to "minfo" and "deh" - use hidden undefined __start/stop_minfo/deh to get start and end of sections - linker will define those symbols (see http://www.airs.com/blog/archives/56) - drop _Dmodule_ref initializers
24b0931 to
8a9ccd2
Compare
|
I want to use this to add a separate section for |
|
Maybe we can combine that with Issue 14816 – improve dt_t data type for faster appending (tail list or array). |
Here is a commit with a similar functionality for the precise GC presented at DConf2013: rainers@e6a3d17 It wrote (address,TypeInfo) pairs, but just emitting pointers to pointers sounds simpler. |
use linker generated section brackets
to get start and end of sections
(see http://www.airs.com/blog/archives/56)