move parameters to stack instead of pushing #5100
Conversation
|
It's green! Pull it quick! |
|
Yep, much better. thanks! |
|
I see Travis is failing. What gives? cc @MartinNowak, @CyberShadow |
|
I have no idea. |
|
No idea, I don't know anything about the Travis tester. I think it is for testing integration for GDC/LDC? I'm not sure. |
|
Travis is checking that the last DMD, GDC and LDC releases(ish) can built DMD master. |
| @@ -267,6 +267,7 @@ void WRFL(enum FL fl) | |||
| "bprel ","frameh","blocko","alloca", | |||
| "stack ","dsym ", | |||
| "got ","gotoff", | |||
| "funcar", | |||
There was a problem hiding this comment.
It has a limit of 6 chars to fit in the array.
There was a problem hiding this comment.
Probably time to remove that limit then, it's only debug code after all.
move parameters to stack instead of pushing
|
Don't ignore failures in the travis autotester. :-) |
It seems that in this case it was an error with GDC's website: I'm not sure what Andrei or Walter could've done here :) |
|
Looks like travis had routing problems on that particular VM. Retry the build? |
* upstream/dmd-1.x: (37 commits) Add ddoc support for 'Template Params' section sync up with D2's backend fold in D2 changes fix build break Merge pull request dlang#5100 from WalterBright/movParams refactor: use LocalSection for alloca data Merge pull request dlang#5076 from WalterBright/AllocOff Merge pull request dlang#5064 from WalterBright/frame Merge pull request dlang#5070 from WalterBright/params Merge pull request dlang#5069 from WalterBright/go4 Merge pull request dlang#5067 from WalterBright/go3 Merge pull request dlang#5066 from WalterBright/go2 Merge pull request dlang#5065 from WalterBright/go Merge pull request dlang#5060 from WalterBright/floatalign Merge pull request dlang#5059 from WalterBright/cstop Merge pull request dlang#5040 from WalterBright/noframe Merge pull request dlang#5051 from WalterBright/movsx Merge pull request dlang#5024 from WalterBright/fakeeh Merge pull request dlang#4978 from WalterBright/rmVBTABLES Merge pull request dlang#4976 from WalterBright/backendgetRtlsym ...
|
This pull request has introduced a regression: |
I've been thinking of doing this for a long time, it's what other compilers do. Instead of
PUSHing parameters on the stack, itMOVes them. Space for it all is preallocated on the stack upon function entry. It's turned on only when-Ois used.The advantage is when there are many function calls, no stack adjustments are done.
There's room for improvement with this, like in how the moves are actually done. This initial support is basic. But it does validate the rather complex changes to make it work. Getting it working enables further optimizations that would be otherwise closed to dmd.