Remove global.gag check in DsymbolExp.resolve() #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an instance that will be converted to a constant exists, the instance representation "foo!tiargs" is treated like a variable name, and its recursive appearance check (note that it's equivalent with a recursive instantiation of foo) is done separately from the circular initialization check for the eponymous enum variable declaration. By the approach, we can remove problematic `global.gag` check in `DsymbolExp::semantic()` without breaking `fail_compilation/diag10141.d`.
|
@WalterBright @yebblies This is a long-standing bug in the front-end code. Please fix! |
|
|
||
| if (!v.type) | ||
| { | ||
| error("forward reference of %s %s", v.kind(), v.toChars()); |
There was a problem hiding this comment.
I know it can be hard to trigger this and the following two error messages, but can a test suite entry be done for them?
|
Auto-merge toggled on |
|
thanks! |
WalterBright
added a commit
that referenced
this pull request
Sep 29, 2015
Remove global.gag check in DsymbolExp.resolve()
|
According to digger, this PR introduced a regression: https://issues.dlang.org/show_bug.cgi?id=19202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #4731.
When an instance that will be converted to a constant exists, the instance representation "foo!tiargs" is treated like a variable name, and its recursive appearance check (note that it's equivalent with a recursive instantiation of foo) is done separately from the circular initialization check for the eponymous enum variable declaration.
By the approach, we can remove problematic
global.gagcheck inDsymbolExp::semantic()without breakingfail_compilation/diag10141.d.