Issue 15094 - __traits(getMember) fails when the source is a struct/class field #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +88,19 @@ extern (C++) static void collectUnitTests(Dsymbols* symbols, AA* uniqueUnitTests | |||
| } | |||
| } | |||
|
|
|||
| // strip off expression context | |||
There was a problem hiding this comment.
Some more explanation of what this function does and why is needed.
|
9rnsr
force-pushed
the
fix15094
branch
2 times, most recently
from
56e96ae
to
87d6efa
Compare
| // It might really be an Expression or an Alias | ||
| ta.resolve(loc, sc, &ea, &ta, &sa); | ||
| ta.resolve(loc, sc, &ea, &ta, &sa, (flags & 1) != 0); |
There was a problem hiding this comment.
Do we have a named flag for this instead of 1?
|
Added ddtailed comments, and fixed auto-tester failure. |
JohanEngelen
added a commit
to weka/ldc
that referenced
this pull request
May 31, 2016
I did not apply all formatting/stylistic changes.
…ct/class field If `TemplateInstance.semanticTiargs` is called from `TraitsExp`, do not strip off the contexts of argument expressions: 1. give `true` to the `intypeid` parameter of `Type.resolve` call. 2. leave `TOKdotvar` and `TOKdottd` as-is.
EyalIO
pushed a commit
to weka/ldc
that referenced
this pull request
Jun 23, 2016
I did not apply all formatting/stylistic changes.
|
Attempted Revival at #7341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15094
If
TemplateInstance.semanticTiargsis called fromTraitsExp, do not strip off the contexts of argument expressions:trueto theintypeidparameter ofType.resolvecall.TOKdotvarandTOKdottdas-is.