[REG2.069.0-rc1] Issue 15253 - inliner prevent compilation #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `again` flag in `expandInline` is just wrong. From the reduced case, if a function that has a delegate parameter contains recursive call, inliner will go into infinite scanning loop. OTOH, the "repeated scanning" idea to see more inline possibility is still good. So I think we don't have to remove the loop in `InlineScanVisitor.visit(FuncDeclaration fd)` and `InlineScanVisitor.again` field. After this change they will become unused, but may be reused in future changes.
|
See also my comments in #5117: |
|
This is the wrong fix - it fixes it by breaking the improvements I'd added earlier (inlining delegate calls). I need to think of how to fix it by not doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15253
Setting
againflag inexpandInlineis just wrong. From the reduced case, if a function that has a delegate parameter contains recursive call, inliner will go into infinite scanning loop.OTOH, the "repeated scanning" idea to see more inline possibility is still good. So I think we don't have to remove the loop in
InlineScanVisitor.visit(FuncDeclaration fd)andInlineScanVisitor.againfield. After this change they will become unused, but may be reused in future changes.