fix Issue 15257 - __traits(compiles, …) with malformed inline asm silently ends compilation #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's one particular test ( fail152.d ) which relies on the incorrect DMD output from before this patch. Not sure what to do in this situation (apart from fix the test of course). |
Yes. |
CyberShadow
changed the title
|
|
It might be worth merging this patch as a temporary workaround, since it seems like a clean solution would involve significant refactoring. Unless someone else thinks they're up to the task. |
I'd rather not. None of the rest of dmd uses exceptions, I don't think we should start now. |
make iasm errors not end compilation dirty hack which works for me (test suite fully passed on my system)
because manual error propagation is so much fun
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| /* | |||
| * Copyright (c) 1992-1999 by Symantec | |||
| * Copyright (c) 1999-2016 by Digital Mars | |||
| * Copyright (c) 1999-2013 by Digital Mars | |||
|
Will open a new pull fixing both the iasm issues i had pulls open for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15257
make iasm errors not end compilation
dirty hack which works for me