-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 15235 - inline asm: silent ICE (segfault) in asm_add_exp( #5248
Conversation
make iasm errors not end compilation dirty hack which works for me (test suite fully passed on my system)
Issue 15235 — iasm.c segfaults
unary minus assumed non-null right-operand
TOKmul could crash without two operands
|
dmd doesn't use EH for reporting errors; I don't really want to start now. I understand that the existing scheme just quits on errors, and this makes it annoying to write the test suite file. A better scheme would be to fix iasm.d so it recovers from errors and continues, like the rest of dmd does, rather than use EH. |
|
P.S. Thanks for tracking down the root cause of this set fault. |
|
Alright then, should I modify this pull so that it doesn't rely on pull/5244 ? |
|
@MartinNowak dlang-bot's comment above looks bugged (same issue number repeated twice) but I can't reproduce this bug locally. |
|
@CyberShadow I can reproduce it very reliably: http://dpaste.dzfl.pl/78292955e3c5 |
|
@Cauterite Sorry, I'm talking about @MartinNowak's dlang-bot, particularly the comment it posted above (the same Bugzilla number repeated twice), this has nothing with your PR or the issues it fixes :) |
|
@CyberShadow Oops, never mind then. |
because manual error propagation is so much fun
|
this will be fixed by the patch for issue 15257 |
https://issues.dlang.org/show_bug.cgi?id=15235