Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 15235 - inline asm: silent ICE (segfault) in asm_add_exp( #5248

Closed
wants to merge 8 commits into from

Conversation

Cauterite
Copy link
Contributor

make iasm errors not end compilation
dirty hack which works for me
(test suite fully passed on my system)
Issue 15235 — iasm.c segfaults
unary minus assumed non-null right-operand
TOKmul could crash without two operands
@Cauterite Cauterite changed the title Issue15235 Issue 15235 - inline asm: silent ICE (segfault) in asm_add_exp( Oct 31, 2015
@WalterBright
Copy link
Member

dmd doesn't use EH for reporting errors; I don't really want to start now. I understand that the existing scheme just quits on errors, and this makes it annoying to write the test suite file. A better scheme would be to fix iasm.d so it recovers from errors and continues, like the rest of dmd does, rather than use EH.

@WalterBright
Copy link
Member

P.S. Thanks for tracking down the root cause of this set fault.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 9, 2015

Fix Bugzilla Description
15235 inline asm: silent ICE (segfault) in asm_add_exp()
15257 __traits(compiles, …) with malformed inline asm silently ends compilation

@Cauterite
Copy link
Contributor Author

Alright then, should I modify this pull so that it doesn't rely on pull/5244 ?

@CyberShadow
Copy link
Member

@MartinNowak dlang-bot's comment above looks bugged (same issue number repeated twice) but I can't reproduce this bug locally.

@Cauterite
Copy link
Contributor Author

@CyberShadow I can reproduce it very reliably: http://dpaste.dzfl.pl/78292955e3c5

@CyberShadow
Copy link
Member

@Cauterite Sorry, I'm talking about @MartinNowak's dlang-bot, particularly the comment it posted above (the same Bugzilla number repeated twice), this has nothing with your PR or the issues it fixes :)

@Cauterite
Copy link
Contributor Author

@CyberShadow Oops, never mind then.

because manual error propagation is so much fun
@Cauterite
Copy link
Contributor Author

this will be fixed by the patch for issue 15257

@Cauterite Cauterite closed this Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants