[REG2.066] Issue 15422 - associative array of nested struct - crash on usage #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a nested struct, built-in generated equality (`tupleof` comparison), hashing (static `xtoHash` function), and assignment (implicitly added `opAssign`) should use its enclosing context identity.
|
Hundreds of lines of nothing but whitespace needs to go in separate PRs. We've discussed this many times. |
9rnsr did that with #5239, then you closed it and asked him to not create PRs like that. |
|
Soo, what will be the fate of this PR? |
9rnsr
force-pushed
the
fix15422
branch
2 times, most recently
from
adf508b to
fe5b3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a nested struct, built-in generated equality (
tupleofcomparison), hashing (staticxtoHashfunction), and assignment (implicitly addedopAssign) should use its enclosing context identity.