[REG2.066] Issue 15422 - associative array of nested struct - crash on usage #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnsr
referenced
this pull request
in 9rnsr/dmd
Dec 14, 2015
On a nested struct, built-in generated equality (`tupleof` comparison), hashing (static `xtoHash` function), and assignment (implicitly added `opAssign`) should use its enclosing context identity.
| if (i == 2) tthis = ad.type.immutableOf(); | ||
| if (i == 3) tthis = ad.type.sharedOf(); | ||
| if (i == 4) tthis = ad.type.sharedConstOf(); | ||
| if (i == 5) break; |
There was a problem hiding this comment.
for (size_t i = 0; i < 5; i++) then turn this into a final switch statement?
There was a problem hiding this comment.
Not sure. When I wrote this code, I thought that other qualifiers (inout, inout const, shared inout etc) might need to be tested here.
|
What's the state of this? |
|
Please submit the hundreds of lines of reformatting and refactoring as a separate PR. |
If a struct is nested in a class, its `vthis` will be reference to the parent class, and struct default equality and hashing considers the parent class equality and hashing. Otherwise, the `vthis` will be typed as void*, and pointer equality and hashing is merely used.
|
Superseded by #5391. It also drops style changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a struct is nested in a class, its
vthiswill be reference to the parent class, and struct default equality and hashing considers the parent class equality and hashing.Otherwise, the
vthiswill be typed as void*, and pointer equality and hashing is merely used.The root problem is an incorrect type for the struct
vthisfield. It has been already filed as Issue 14442, so this PR fixes it, and then issue 15422 will be fixed naturally.