[REG2.067] Issue 15681 - Nested user type enum not retaining value properly #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It was a bug in `createBlockDuplicatedArrayLiteral` function. On array literal construction, the element should be copied when the type has value semantics and the CTFE value has sub payload. 2. Also the `createBlockDuplicatedArrayLiteral` callers need to handle the `elem` argument ownership well. 2a. In `copyLiteral`, it didn't copy the source struct element on block assignment. 2b. In `recursivelyCreateArrayLiteral`, the `elemType.defaultInitLiteral(loc)` is not yet CTFE-ed expression. So it should be interpreted to copy it into CTFE world.
|
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Feb 23, 2016
[REG2.067] Issue 15681 - Nested user type enum not retaining value properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createBlockDuplicatedArrayLiteralfunction. On array literal construction, the element should be copied when the type has value semantics and the CTFE value has sub payload.createBlockDuplicatedArrayLiteralcallers need to handle theelemargument ownership well.2a. In
copyLiteral, it didn't copy the source struct element on block assignment.2b. In
recursivelyCreateArrayLiteral, theelemType.defaultInitLiteral(loc)is not yet CTFE-ed expression. So it should be interpreted to copy it into CTFE world.