Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable warnings during D compilation and fix all warnings #5482

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

JohanEngelen
Copy link
Contributor

I have tried to fix all warnings in the way that seemed most "correct" to me.

See forum discussion here: http://forum.dlang.org/thread/xkftumtlbvmsrjrkedbh@forum.dlang.org

tested wih dmd 2.069.0 and 2.070.0

@JohanEngelen
Copy link
Contributor Author

While working on this, I stumbled on what appears to be a bug: https://issues.dlang.org/show_bug.cgi?id=15731

@@ -146,6 +146,8 @@ CXXFLAGS += \
endif
# Default D compiler flags for all source files
DFLAGS=
# Enable D warnings
DFLAGS += -w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed.

@JohanEngelen
Copy link
Contributor Author

@yebblies Fixed -wi, squashed and rebased on master, looked green on all testers.

@dnadlinger
Copy link
Member

Auto-merge toggled on

dnadlinger added a commit that referenced this pull request Feb 28, 2016
Enable warnings during D compilation and fix all warnings
@dnadlinger dnadlinger merged commit ffadcd8 into dlang:master Feb 28, 2016
@JohanEngelen JohanEngelen deleted the fix_warnings branch February 28, 2016 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants