[REG2.066] Issue 15733 - Forward reference issue involving inheritance #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| scx.setNoFree(); | ||
| } | ||
| _scope = scx; | ||
| scope (exit) _scope = null; |
There was a problem hiding this comment.
Using scope exit involves creating an exception handling frame. However, none of dmd throws exceptions, making this inefficient. Just set _scope to null after the call to exp().
9rnsr
force-pushed
the
fix15733
branch
2 times, most recently
from
473e414 to
f1babec
Compare
|
Auto-merge toggled on |
|
Thanks, but the auto-merge is currently blocked by the red of Phobos unittest in stable branch. |
WalterBright
added a commit
that referenced
this pull request
Mar 19, 2016
[REG2.066] Issue 15733 - Forward reference issue involving inheritance
tramker
added a commit
to tramker/dmd
that referenced
this pull request
Sep 17, 2016
[REG2.066] Issue 15733 - Forward reference issue involving inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.