fix Issue 15323 - Module.members and .deferred3 should use data struc… #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalterBright
force-pushed
the
fix15323
branch
2 times, most recently
from
98c059f to
0cde105
Compare
…ture with fast lookup
| a = null; | ||
| break; | ||
| auto a = mi.members; | ||
| for (size_t i = 0; 1; ++i) |
There was a problem hiding this comment.
that 1 is confusing, should be removed
|
Auto-merge toggled on |
| @@ -8008,22 +8011,26 @@ public: | |||
| } | |||
| //printf("\t--> mi = %s\n", mi.toPrettyChars()); | |||
|
|
|||
| Dsymbols* a = mi.members; | |||
| for (size_t i = 0; 1; i++) | |||
| if (memberOf is mi) // already a member | |||
There was a problem hiding this comment.
I'd have probably written if (memberOf) { assert(memberOf is mi); … } to make it clearer how this is supposed to behave.
|
@andralex - Out of curiousity, why do you make a comment asking for a change, then hit "merge" anyway? If something "should be removed" then surely that should be ratified before taking the change in. |
JohanEngelen
added a commit
to weka/ldc
that referenced
this pull request
Apr 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture with fast lookup