4135 Regression(1.034): ICE(statement.c): mixin in bad foreach, D1 only #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error propagation -- if we don't know what we're iterating over, quit immediately (it might even be supposed to be a tuple).
WalterBright
added a commit
that referenced
this pull request
Dec 19, 2011
4135 Regression(1.034): ICE(statement.c): mixin in bad foreach, D1 only
|
I'm curious why this doesn't apply to D2. |
|
It doesn't ICE in D2 because the foreach semantic is very different, it already exits before doing type deduction of the parameters Still, quitting immediately (as in this patch) would be OK to do in D2 as well. |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Fix Issue 6580 - scoped classes are aligned incorrectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This is a pull request for D1 only.
A simple error propagation bug -- we should abandon hope if we don't know what the aggregate is.