Issue 6939 & 6940 & 7136 - Fix type combination #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const int[] c; | ||
| static assert( is(typeof(1?a:b) == shared(const(int))[])); // pass (ok) | ||
| static assert(!is(typeof(1?a:b) == const(int)[])); // pass (ok) | ||
| static assert(!is(typeof(1?x:z))); // fail |
There was a problem hiding this comment.
Should be
static assert(!is(typeof(1?a:c)));
|
Does this fix the case (1?immutable(int)_ : int_) -> const(int*)* that is briefly discussed under 6940? It does not occur in the tests. |
|
Wow, I had forgotten it. Added fix and test case. |
WalterBright
added a commit
that referenced
this pull request
Dec 20, 2011
Issue 6939 & 6940 & 7136 - Fix type combination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 6939 - wrong type qualifier combination
Issue 6940 - immutable(int_)_/immutable(int)* and int* do not combine
Issue 7136 - alias this lookup should run before merging modifiers of both sides.