Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinterpret.d: replace static if with version #5767

Merged
merged 1 commit into from
May 12, 2016

Conversation

WalterBright
Copy link
Member

trivial

@UplinkCoder
Copy link
Member

LGTM!
Great!

@yebblies
Copy link
Member

How is this not churn?

@joakim-noah
Copy link
Contributor

joakim-noah commented May 12, 2016

LGTM. The only wider implication I see for this is that there are several other files using some kind of static if (LOG), so if we change all those to version (LOG) also, a simple -version=LOG passed to the build will turn them all on, whereas each of their logging is turned on on a file-by-file basis now.

May be worth thinking about changing all these to debug (LOG) instead and figuring out what names you want to use to differentiate them across modules, if that kind of separation is wanted.

@yebblies
Copy link
Member

You're right, debug (XXX) would be more appropriate.

@WalterBright
Copy link
Member Author

How is this not churn?

It's not what static if is for, the way it is used in the file is more of a C++ way of doing things than a D way.

@yebblies
Copy link
Member

Well, you know how I feel about version. But debug at least does theoretically help with attributes later on.

@yebblies
Copy link
Member

Auto-merge toggled on

@yebblies yebblies merged commit 0757504 into dlang:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants