fix Issue 15399 - unaligned pointers are not @safe #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking the address too? |
WalterBright
force-pushed
the
fix15399
branch
3 times, most recently
from
813e4d2 to
9f9b45b
Compare
|
Toto too! |
| bar(s2.ptr); | ||
| sinister(s1.ptr); | ||
| sinister(s2.ptr); | ||
| } |
There was a problem hiding this comment.
What about int x = *s1.ptr and *s1.ptr = 42?
There was a problem hiding this comment.
It's writing a new value to the misaligned pointer that is the problem, not dereferencing it.
There was a problem hiding this comment.
Alright, tnx for the explanation.
|
|
||
| bool checkMisalignedPointer(Scope* sc, Expression e, string msg) | ||
| { | ||
| if (e.op == TOKdotvar) |
There was a problem hiding this comment.
This is a prime example of that pattern that should be replaced with:
if (e.op != TOKdotvar)
return false;
... interesting branch ...Clarifies the charter of the scope and unindents everything that's interesting.
|
ok modulo pet peeve |
|
@andralex rebased, working now |
|
Auto-merge toggled on |
PetarKirov
added a commit
to PetarKirov/D-YAML
that referenced
this pull request
Nov 4, 2016
The following DMD PRs added more rigorous safety checks directly affecting this project: * dlang/dmd#5852 (fix Issue 15399 - unaligned pointers are not `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/emitter.d#L1011 * dlang/dmd#5940 (Unions may break immutability / unions with pointers are un-`@safe` ) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/event.d#L230 * dlang/dmd#5876 (Casting from `void[]` to `T[]` is erroneously considered `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/loader.d#L186 * dlang/dmd#5860 (array.ptr in @safe code may point past end of array) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/zerostring.d#L35
PetarKirov
added a commit
to PetarKirov/D-YAML
that referenced
this pull request
Nov 4, 2016
The following DMD PRs added more rigorous safety checks directly affecting this project: * dlang/dmd#5852 (fix Issue 15399 - unaligned pointers are not `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/emitter.d#L1011 * dlang/dmd#5940 (Unions may break immutability / unions with pointers are un-`@safe` ) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/event.d#L230 * dlang/dmd#5876 (Casting from `void[]` to `T[]` is erroneously considered `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/loader.d#L186 * dlang/dmd#5860 (array.ptr in @safe code may point past end of array) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/zerostring.d#L35
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Mar 5, 2017
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Mar 5, 2017
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.