Issue 3235 & 6714 - [tdpl] Improve function literal deduction #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuncExp::setType should be called first, and later semantic() resolve parameter types from tded.
1. The first FuncExp::semantic() call saves scope. 2. Next FuncExp::inferType() tries to resolve parameter types. 3. And finally setType() + semantic() determine the actual type (see functionParameters).
If FuncLiteralDeclaration::tok == TOKreserved, it is lambda declaration that is not yet determined as neither function or delegate.
Bad covariant conversion from float(int,int) to double(int,int) was incorrectly allowed.
|
Whole improvement for bug 3235. |
|
If you merge this pull, please merge dlang/phobos#381 at the same time. |
WalterBright
added a commit
that referenced
this pull request
Dec 31, 2011
Issue 3235 & 6714 - [tdpl] Improve function literal deduction
|
Why is it OK to break existing code? Was this breaking change discussed in the NG? |
|
On 12/31/2011 9:00 AM, Andrej Mitrovic wrote:
The deciding factor for me was the improvement in code performance. |
|
@WalterBright, this change was a bit fragile. |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Issue 8112 - std.algorithm.fill must accept InputRange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 3235 - [tdpl] Function literals must be deduced as "function" or "delegate"
Issue 6714 - [tdpl] Type inference for parameters of function and delegate literals
Features:
Var declaration, return statement, caller (
CallExp::e1), and argument of function call.A small breaking of existing code:
Past normal function literals, not in template arguments, are can omit parameter names.
e.g.
(string, size_t){ return 1024; }But this change regards them as parameter type omission, then raises an error.
Supplemental changes of Phobos:
dlang/phobos#381