Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fix for bug 314 (previously pull request 190). #591

Merged
merged 1 commit into from
Jan 1, 2012

Conversation

ckamm
Copy link

@ckamm ckamm commented Dec 31, 2011

See #190

@braddr
Copy link
Member

braddr commented Dec 31, 2011

While the failures in the pull auto-tester are likely not entirely due to the patch itself, the problems exposed by the changes should probably be fixed prior to this pull request landing.

http://d.puremagic.com/test-results/pulls.ghtml
http://d.puremagic.com/test-results/pull.ghtml?runid=14215 -- win32 failures

std\datetime.d(30070): Error: undefined identifier toUTF16
std\datetime.d(30071): Error: undefined identifier toUTF16

@WalterBright
Copy link
Member

I agree. Jonathan? Can you have a look and see if this is an std.datetime problem or a problem with the pull?

@ckamm
Copy link
Author

ckamm commented Jan 1, 2012

It looks like std.datetime should import std.utf. It worked previously because std.datetime imports std.windows.registry which has a private selective import for toUTF16.

WalterBright added a commit that referenced this pull request Jan 1, 2012
Updated fix for bug 314 (previously pull request 190).
@WalterBright WalterBright merged commit ff9fa25 into dlang:master Jan 1, 2012
MartinNowak added a commit to MartinNowak/dmd that referenced this pull request Feb 11, 2012
This reverts commit ff9fa25, reversing
changes made to 227769c.
@MartinNowak MartinNowak mentioned this pull request Feb 11, 2012
@WalterBright
Copy link
Member

Note that the original pull on this included no test cases, which means when it was reverted that the test suite still passed, but the bugzilla example now fails again.

braddr pushed a commit to braddr/dmd that referenced this pull request Oct 22, 2012
Fix empty range creation when using stride.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants