Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue 4523 - [tdpl] .remove method for Associative Arrays returns void in all cases #597

Merged
merged 1 commit into from Jan 9, 2012

Conversation

Projects
None yet
3 participants
Member

9rnsr commented Jan 2, 2012

Owner

andralex commented Jan 2, 2012

This is continuing the tradition of changing the compiler to special-case associative arrays. Although this works, I think it would be great to transfer an increasing amount of responsibility from the compiler to the associative array type included in druntime object.d.

@ghost

ghost commented Jan 2, 2012

Edit: Oops, I didn't realize there was another pull, sorry for the comment!

Member

9rnsr commented Jan 3, 2012

To @andralex
Yes, I had planned it first, but discarded it by following reasons.

  • Current dmd compiler translates aa.remove() to special AST node RemoveExp.
  • CTFE interpreter uses RemoveExp to support AA operation.

WalterBright added a commit that referenced this pull request Jan 9, 2012

Merge pull request #597 from 9rnsr/fix4523
Issue 4523 - [tdpl] .remove method for Associative Arrays returns void in all cases

@WalterBright WalterBright merged commit 1f14a6e into dlang:master Jan 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment