[trivial] parseAttribute() error message did not mention @nogc #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cauterite, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yebblies, @9rnsr and @WalterBright to be potential reviewers. @yebblies: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
| @@ -1384,7 +1384,8 @@ final class Parser : Lexer | |||
| *pudas = UserAttributeDeclaration.concat(*pudas, udas); | |||
| } | |||
| else | |||
| error("valid attributes are @property, @safe, @trusted, @system, @disable"); | |||
| error("valid attributes are @%s, @%s, @%s, @%s, @%s, @%s", | |||
There was a problem hiding this comment.
Just have a string, please!
There was a problem hiding this comment.
But what's the point of having Idgen if we're just hardcoding the identifiers anyway?
There was a problem hiding this comment.
The point is to make them work as identifiers for the lexer.
Current coverage is 87.42% (diff: 100%)@@ master #6084 diff @@
==========================================
Files 97 97
Lines 56166 56166
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 49101 49101
Misses 7065 7065
Partials 0 0
|
Cauterite
force-pushed
the
parserpatch1
branch
from
f816de8 to
142bb4a
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code is self-explanatory